svn commit: trunk/uClibc: extra/scripts

Carmelo AMOROSO carmelo.amoroso at st.com
Wed May 7 02:47:47 PDT 2008


Denys Vlasenko wrote:
> On Wednesday 07 May 2008 09:49, Carmelo AMOROSO wrote:
>   
>> Hello, just some comments...
>>     
>
>   
>>> It also installs asm[-generic] and linux subdirs from kernel headers
>>> (previously it had to be done separately).
>>>       
>> why ? I'd disagree with this choice.... it brakes some more complex 
>> build system
>> where kernel-headers are installed in other way (i.e. rpm based build 
>> system).
>>     
>
> I found it usefult. Before this, I had to copy kernel headers
> to installed uclibc' include dir by hand. Every time. Not funny.
>
> If one builds his libc against a set of kernel headers X he's better
> not use built libc and its headers with different set of kernel headers Y!
> Sure, kernel is supposed to provide stable API, but this inevitably
> breaks in some more obscure corners.
>
> Having said that, I understand that this constitutes a change
> from previous behavior.
>
> I propose introducing "make install_kernel_headers"
> for those who needs it.
>
> Is this acceptable for you?
>
>   
Hi Denis,
thanks for your explanation... yes this sounds good me.
So who need to install only libc headers, will call make 
install_headers... who needs both
will call make install_kernel_headers too.
I think it's more flexible.

Thanks,
Carmelo
>>> Lastly, it passes each uclibc header thru unifdef, which strips
>>> #ifdef UCLIBC_INTERNAL conditional from headers.
>>>   
>>> Currently it's a no-op (no such #ifders in tree).
>>> The plan is to have libc_hidden_proto(foo) migrated to headers
>>> and guard them by these #ifdefs.
>>>       
>> so, the final choice was to use this approach.. just for confirmation.
>>     
>
> Yes.
>
> This will also trivially extendable to remove other extraneous/internal
> stuff, for example:
>
> ./nl_types.h:#ifdef __UCLIBC_MJN3_ONLY__
> ./time.h:#ifdef __UCLIBC_MJN3_ONLY__
> ./time.h:#ifdef __UCLIBC_MJN3_ONLY__
> ./time.h:#ifdef __UCLIBC_MJN3_ONLY__
>
> --
> vda
>
>   



More information about the uClibc-cvs mailing list