[patch] string cosmetics for SUSV3_LEGACY

Bernhard Fischer rep.nop at aon.at
Thu Jul 6 02:34:15 PDT 2006


Hi,

The attached patch makes sure that we do not create empty object files
when SUSV3_LEGACY functions are turned off.

Ok?

Also, i'd like to know if it is a good idea to provide fallback defines
for the bcopy/bzero et al if SUSV3_LEGACY was explicitly turned off?
I certainly would have expected that these (impls and fallback defines)
are _not_ available at all when i turned the option to support them off.

thanks,
-------------- next part --------------
Index: uClibc/libc/string/Makefile.in
===================================================================
--- uClibc/libc/string/Makefile.in	(revision 15655)
+++ uClibc/libc/string/Makefile.in	(working copy)
@@ -17,6 +17,12 @@ STRING_ARCH_OBJ := $(patsubst $(STRING_A
 STRING_ARCH_SSRC := $(wildcard $(STRING_ARCH_DIR)/*.S)
 STRING_ARCH_SOBJ := $(patsubst $(STRING_ARCH_DIR)/%.S,$(STRING_ARCH_OUT)/%.o,$(STRING_ARCH_SSRC))
 
+ifneq ($(UCLIBC_SUSV3_LEGACY),y)
+STRING_ALL_SUSV3LEGACY := bcopy bzero
+STRING_ARCH_OBJ := $(filter-out $(patsubst %,$(STRING_ARCH_OUT)/%.o,$(STRING_ALL_SUSV3LEGACY)),$(STRING_ARCH_OBJ))
+STRING_ARCH_SOBJ := $(filter-out $(patsubst %,$(STRING_ARCH_OUT)/%.o,$(STRING_ALL_SUSV3LEGACY)),$(STRING_ARCH_SOBJ))
+endif
+
 STRING_ARCH_OBJS := $(STRING_ARCH_OBJ) $(STRING_ARCH_SOBJ)
 
 libc-$(UCLIBC_HAS_STRING_ARCH_OPT) += $(STRING_ARCH_OBJS)
@@ -71,7 +77,13 @@ else
 STRING_WSRC := $(filter-out $(STRING_DIR)/wcsxfrm.c,$(STRING_ALL_WSRC))
 endif
 
-STRING_ALL_CSRC := $(filter-out $(STRING_ALL_WXSRC) $(STRING_ALL_XLSRC) $(STRING_ALL_WSRC) $(STRING_DIR)/_collate.c,$(wildcard $(STRING_DIR)/*.c))
+ifeq ($(UCLIBC_SUSV3_LEGACY),y)
+STRING_SUSV3LEGACY :=
+else
+STRING_SUSV3LEGACY := $(patsubst %,$(STRING_DIR)/%.c,$(STRING_ALL_SUSV3LEGACY))
+endif
+
+STRING_ALL_CSRC := $(filter-out $(STRING_ALL_WXSRC) $(STRING_ALL_XLSRC) $(STRING_ALL_WSRC) $(STRING_DIR)/_collate.c $(STRING_SUSV3LEGACY),$(wildcard $(STRING_DIR)/*.c))
 ifeq ($(UCLIBC_HAS_LOCALE),y)
 STRING_CSRC := $(STRING_ALL_CSRC)
 else


More information about the uClibc mailing list