[PATCH] Re: readahead offset type (re: mantis 0001024)

[Bernhard Fischer]

On Wed, Jan 31, 2007 at 10:50:45PM +0100, Yann E. MORIN wrote:
>Hello all!
>
>On Monday 29 January 2007 204, Bernhard Fischer wrote:
>> Index: libc/sysdeps/linux/common/Makefile.in
>> ===================================================================
>> --- libc/sysdeps/linux/common/Makefile.in       (revision 17626)
>> +++ libc/sysdeps/linux/common/Makefile.in       (working copy)
>> @@ -16,7 +16,7 @@
>>  
>>  ifneq ($(UCLIBC_HAS_LFS),y)
>>  CSRC_LFS := $(notdir $(wildcard $(COMMON_DIR)/*64.c))
>> -CSRC := $(filter-out llseek.c $(CSRC_LFS),$(CSRC))
>> +CSRC := $(filter-out readahead.c llseek.c $(CSRC_LFS),$(CSRC))
>>  endif
>>  
>>  CSRC := $(filter-out ssp-local.c,$(CSRC))
>
>When will this make it into svn?

Well, do we -ENOSYS if something isn't available?
If so, then we should rather
#ifdef __NR_readahead
[snip current code]
#else
ssize_t readahead(int fd, off_t offset, size_t count)
{
	__set_errno(ENOSYS);
	return -1;
}
link_warning(readahead,"not available")
#endif

Wondering if there should be a generic internal helper stub for
the ENOSYS;ret -1 case..