[PATCH] clean up compiler warnings in libc/stdio/vfprintf.c

[Al Stone]

On Thu, 2007-03-08 at 14:35 +0000, Luciano Miguel Ferreira Rocha wrote:
> On Thu, Mar 08, 2007 at 09:23:08AM -0500, Rob Landley wrote:
> > On Thursday 08 March 2007 8:05 am, Luciano Miguel Ferreira Rocha wrote:
> > > On Thu, Mar 08, 2007 at 07:51:47AM -0500, Rob Landley wrote:
> > > > Is there any kind of --shutup-about-signedness-of-char-already flag we can 
> > > > pass to the darn compiler?
> > > > 
> > > 
> > > -Wno-pointer-sign?
> > >   Don't warn for pointer argument passing or assignment with different
> > >   signedness.
> > 
> > Except that shuts it up for short, int and long as well.
> 
> True, but, again, only for f(*arg) and *a = *v. Do you see problems
> arising from that in your code? (Or most code, for that matter.)

Personally, almost never.

I'm sure it's a stylistic thing, but I personally prefer that
there is explicit code to silence the warning; a global switch
may inadvertently hide a warning I _should_ see.  And, if for
some reason something changes so that the cast no longer works
properly, I like knowing that, too.

I'll be the first to admit that I'm new enough to uClibc that
I don't know if this sort of thing has been dealt with and some
convention already arrived at...

-- 
Ciao,
al
----------------------------------------------------------------------
Al Stone                                      Alter Ego:
Open Source and Linux R&D                     Debian Developer
Hewlett-Packard Company                       http://www.debian.org
E-mail: ahs3 at fc.hp.com                        ahs3 at debian.org
----------------------------------------------------------------------