[PATCH] sh: fix build after changes made on rev 18095
Carmelo Amoroso
carmelo73 at gmail.com
Sun Mar 25 12:19:32 PDT 2007
Mike Frysinger wrote:
> On Monday 19 March 2007, Carmelo AMOROSO wrote:
>> the change made on libc/sysdeps/linux/sh/user.h brakes build on sh4,
>> due to redefinition of 'user_fpu_struct' and 'user' structs caused
>> by the following include chain:
>>
>> sys/procfs.h -> asm/elf.h -> asm/user.h
>> sys/procfs.h -> asm/user.h
>>
>> Simply removing the asm/user.h include from procfs.h it compiles again.
>> The attached patch solves it and add some other minor changes grabbed
>> from glibc.
>
> i feel like this just delays the problem ... when random source XXX includes
> sys/user.h and sys/procfs.h (which is quite legit), it'll fall apart
>
I agree
> why not replace asm/elf.h in favor of elf.h ?
asm/elf.h is required only for elf_gregset and elf_fpregset_t typedefs.
These two typedef can be safely added to the procfs.h file itself,
just like all other architectures, removing the inclusion of asm/elf.h.
So, right, I'll post a new patch later.
Carmelo
> -mike
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> uClibc mailing list
> uClibc at uclibc.org
> http://busybox.net/cgi-bin/mailman/listinfo/uclibc
More information about the uClibc
mailing list