[PATCH] yet another compiler warning cleanup

Al Stone ahs3 at fc.hp.com
Tue Mar 27 17:32:45 PDT 2007


This time, the compiler was right -- there was a path where you could
return an unknown value from gethostent_r() in libc/inet/resolv.c.
OTOH, it's not clear anyone actually uses the return value, so it's
not clear fixing it is essential -- tidy, perhaps, but not essential.
The value returned may not be the best choice but seemed reasonable.

Signed-off-by: Al Stone <ahs3 at fc.hp.com>


--- libc/inet/resolv.c
+++ libc/inet/resolv.c
@@ -1696,6 +1696,7 @@
        __open_etc_hosts(&__gethostent_fp);
        if (__gethostent_fp == NULL) {
            *result=NULL;
+           ret=TRY_AGAIN;
            goto DONE;
        }
     }


-- 
Ciao,
al
----------------------------------------------------------------------
Al Stone                                      Alter Ego:
Open Source and Linux R&D                     Debian Developer
Hewlett-Packard Company                       http://www.debian.org
E-mail: ahs3 at fc.hp.com                        ahs3 at debian.org
----------------------------------------------------------------------



More information about the uClibc mailing list