[PATCH] posix_fadvise, posix_fadvise64 should return error code

Atsushi Nemoto anemo at mba.ocn.ne.jp
Fri May 25 08:21:54 PDT 2007


http://www.opengroup.org/onlinepubs/009695399/functions/posix_fadvise.html
states it returns error code instead of setting errno.

 libc/sysdeps/linux/arm/posix_fadvise.c      |    3 +--
 libc/sysdeps/linux/arm/posix_fadvise64.c    |    3 +--
 libc/sysdeps/linux/common/posix_fadvise.c   |    3 +--
 libc/sysdeps/linux/common/posix_fadvise64.c |    3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)
-------------- next part --------------
diff -urNp -x '*~' uClibc-0.9.29.org/libc/sysdeps/linux/arm/posix_fadvise.c uClibc-0.9.29/libc/sysdeps/linux/arm/posix_fadvise.c
--- uClibc-0.9.29.org/libc/sysdeps/linux/arm/posix_fadvise.c	2007-03-07 04:13:31.000000000 +0900
+++ uClibc-0.9.29/libc/sysdeps/linux/arm/posix_fadvise.c	2007-05-25 12:25:48.000000000 +0900
@@ -30,8 +30,7 @@ weak_alias(__libc_posix_fadvise, posix_f
 #else
 int posix_fadvise(int fd attribute_unused, off_t offset attribute_unused, off_t len attribute_unused, int advice attribute_unused)
 {
-        __set_errno(ENOSYS);
-        return -1;
+	return ENOSYS;
 }
 #endif
 
diff -urNp -x '*~' uClibc-0.9.29.org/libc/sysdeps/linux/arm/posix_fadvise64.c uClibc-0.9.29/libc/sysdeps/linux/arm/posix_fadvise64.c
--- uClibc-0.9.29.org/libc/sysdeps/linux/arm/posix_fadvise64.c	2007-03-07 04:13:31.000000000 +0900
+++ uClibc-0.9.29/libc/sysdeps/linux/arm/posix_fadvise64.c	2007-05-25 12:26:02.000000000 +0900
@@ -40,8 +40,7 @@ weak_alias(__libc_posix_fadvise64, posix
 #else
 int posix_fadvise64(int fd, __off64_t offset, __off64_t len, int advise)
 {
-        __set_errno(ENOSYS);
-        return -1;
+	return ENOSYS;
 }
 #endif
 #endif
diff -urNp -x '*~' uClibc-0.9.29.org/libc/sysdeps/linux/common/posix_fadvise.c uClibc-0.9.29/libc/sysdeps/linux/common/posix_fadvise.c
--- uClibc-0.9.29.org/libc/sysdeps/linux/common/posix_fadvise.c	2007-03-06 17:06:26.000000000 +0900
+++ uClibc-0.9.29/libc/sysdeps/linux/common/posix_fadvise.c	2007-05-25 12:26:51.000000000 +0900
@@ -46,7 +46,6 @@ strong_alias(posix_fadvise,posix_fadvise
 #else
 int posix_fadvise(int fd attribute_unused, off_t offset attribute_unused, off_t len attribute_unused, int advice attribute_unused)
 {
-	__set_errno(ENOSYS);
-	return -1;
+	return ENOSYS;
 }
 #endif
diff -urNp -x '*~' uClibc-0.9.29.org/libc/sysdeps/linux/common/posix_fadvise64.c uClibc-0.9.29/libc/sysdeps/linux/common/posix_fadvise64.c
--- uClibc-0.9.29.org/libc/sysdeps/linux/common/posix_fadvise64.c	2007-03-06 17:06:26.000000000 +0900
+++ uClibc-0.9.29/libc/sysdeps/linux/common/posix_fadvise64.c	2007-05-25 12:26:31.000000000 +0900
@@ -74,8 +74,7 @@ int posix_fadvise64(int fd, __off64_t of
  */
 int posix_fadvise64(int fd, __off64_t offset, __off64_t len, int advice)
 {
-	__set_errno(ENOSYS);
-	return -1;
+	return ENOSYS;
 }
 #endif /* __NR_fadvise64_64 */
 #endif /* __UCLIBC_HAS_LFS__ */


More information about the uClibc mailing list